-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-client-bom from 6.8.1 to 6.9.2 #36312
Conversation
@metacosm let us know if it's all good for you. |
This comment has been minimized.
This comment has been minimized.
|
Local build and test passed for This is the GraalVM output:
This release of the client includes new Kubernetes v1.28 model types for the |
Unfortunately, I'm not sure we can go much higher than 5g on GitHub Actions without having things failing. Maybe try to set |
3cf07f8
to
dc637ed
Compare
This comment has been minimized.
This comment has been minimized.
No, it's not good for us. Applications don't compile anymore with errors similar to: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project sample-webpage-operator: Compilation failure: Compilation failure:
[ERROR] /Volumes/CaseSensitiveDev/java-operator-sdk/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageStandaloneDependentsReconciler.java: accept(java.util.List<java.util.Map.Entry<java.lang.String,java.lang.Object>>,java.lang.String,io.fabric8.kubernetes.api.builder.Visitor...) in io.fabric8.kubernetes.api.builder.BaseFluent cannot implement accept(java.util.List<java.util.Map.Entry<java.lang.String,java.lang.Object>>,java.lang.String,io.fabric8.kubernetes.api.builder.Visitor...) in io.fabric8.kubernetes.api.builder.Visitable
[ERROR] return type capture#1 of ? is not compatible with capture#2 of ?
[ERROR] /Volumes/CaseSensitiveDev/java-operator-sdk/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageDependentsWorkflowReconciler.java: accept(java.util.List<java.util.Map.Entry<java.lang.String,java.lang.Object>>,java.lang.String,io.fabric8.kubernetes.api.builder.Visitor...) in io.fabric8.kubernetes.api.builder.BaseFluent cannot implement accept(java.util.List<java.util.Map.Entry<java.lang.String,java.lang.Object>>,java.lang.String,io.fabric8.kubernetes.api.builder.Visitor...) in io.fabric8.kubernetes.api.builder.Visitable
[ERROR] return type capture#3 of ? is not compatible with capture#4 of ? Note that this occurs in code that doesn't use this method so there's nothing that can be done on our side as the error occurs outside of our code. The same code works fine with 6.8.1. |
@manusa see comment above ^ |
Yes, sorry for not commenting here. There's some work being done, I created fabric8io/kubernetes-client#5522 to keep track of it. I'm not sure if @metacosm has been able to try this weekend's snapshots to see if there's any difference. I tried to create a simple reproducer in the main Fabric8 repository, but was unable to. @iocanel was doing some research on the subject, but I'm not sure if he found out anything else. |
dc637ed
to
da8eb4e
Compare
Hi @metacosm I've updated the PR to bump Kubernetes Client to 6.9.1 which contains the fix for the type inference issue. Please check if it solves your issue. |
This comment has been minimized.
This comment has been minimized.
It seems we need to bump Dekorate's dependency on Sundrio too |
da8eb4e
to
d4ac8cb
Compare
This comment has been minimized.
This comment has been minimized.
Looking into it, seems like type inference is stricter now. |
Moving past that issue, I get other errors similar to: |
The error I'm seeing is consistent with CI here. I guess we need a dekorate upgrade as well. |
d4ac8cb
to
55ebb24
Compare
I updated the PR to include Dekorate's updated version that Ioannis just released. |
3c45f8d
to
10b2dfc
Compare
I've got something working, but I'll need some feedback on this. The main issue with the GraalVM out of memory error is regarding the presence of a really big model module ( This model will only be required by a fraction of users and for sure is not part of the integration test suite. An easy way to overcome the out of memory problem is to exclude this module in the My proposed solution is to add a config property: I guess this needs a wider consensus though. Or maybe there's a more suitable solution that I didn't think of. @geoand @gastaldi @gsmet |
This comment has been minimized.
This comment has been minimized.
I don't think this is the way to go, as we almost never want extensions to be adding global GraalVM flags. |
Well, in this case is not adding, but providing a configuration option to prevent Quarkus from adding a flag automatically. I'd rather see #25526 fixed instead too. |
My point is that the an extension is making changes to GraalVMs's globak configuration |
It's basically the same as this, but with an option to opt-in. |
Yeah, that's a very very special case that we try very hard to avoid |
So what is the proposed solution, @geoand? We need an update to the client in Quarkus. |
@manusa is working on it after a chat we had |
I'm currently working on one. Since this only affects GH actions environment, I'm adding some hack extension to the kubernetes/openshift-client integration test modules that prevents the |
Prevent Quarkus from adding --link-at-build-time GraalVM flag Signed-off-by: Marc Nuri <[email protected]>
10b2dfc
to
26713db
Compare
Failing Jobs - Building 26713db
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Maven Tests - JDK 11 Windows #📦 integration-tests/maven✖
✖
|
Woot! 💪 |
Kubernetes Client 6.9.0 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.9.0Kubernetes Client 6.9.1 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.9.1Kubernetes Client 6.9.2 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.9.2
/cc @metacosm